Skip to content

cli: use shlex tokenization when parsing dot commands arguments#7391

Open
pauliyobo wants to merge 2 commits into
tursodatabase:mainfrom
pauliyobo:issue7338
Open

cli: use shlex tokenization when parsing dot commands arguments#7391
pauliyobo wants to merge 2 commits into
tursodatabase:mainfrom
pauliyobo:issue7338

Conversation

@pauliyobo
Copy link
Copy Markdown

Use shlex tokenization to parse dot commands arguments in all cases.
This allows using quoted strings which contain white spaces to be treated as a single argument, allowing for example paths with spaces, as reported in #7338
Fixes #7338

@pauliyobo pauliyobo requested a review from penberg as a code owner June 5, 2026 11:52
@github-actions github-actions Bot added the cli label Jun 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Fossier: Manual Review Requested

@pauliyobo is a new contributor. A maintainer should review this PR before merging.

Score Breakdown

Total Score: 50.4/100 | Confidence: 100% | Outcome: REVIEW

Signal Value Score Weight
account_age 3103 1.00 0.07
public_repos 43 1.00 0.04
contribution_history 43 0.21 0.04
follower_ratio 0.89 0.44 0.04
bot_signals False 0.50 0.03
open_prs_elsewhere 5 0.38 0.07
closed_prs_elsewhere 3 0.70 0.08
merged_prs_elsewhere 34 1.00 0.06
prior_interaction 0 0.00 0.24
activity_velocity 1 1.00 0.06
pr_content ... 1.00 0.06
commit_email no_email 0.50 0.03
pr_description ... 0.70 0.04
repo_stars 19082 0.30 0.03
org_membership 0 0.20 0.02
commit_verification ... 0.30 0.03
contributor_stars 10 0.20 0.03

@LeMikaelF
Copy link
Copy Markdown
Collaborator

please add tests

@pauliyobo
Copy link
Copy Markdown
Author

Hello,
@LeMikaelF sounds good.
In this case which kind of test would be more appropriate? Is it fine to add unit tests that handle the arguments parsing or were you meaning integration tests?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: tursodb: Can not open path with space

2 participants