feat: deprecate --style=auto in favor of --decorations=auto (fixes #3752)#3770
Open
leno23 wants to merge 2 commits into
Open
feat: deprecate --style=auto in favor of --decorations=auto (fixes #3752)#3770leno23 wants to merge 2 commits into
leno23 wants to merge 2 commits into
Conversation
Emit a bat warning when the deprecated `auto` style component is used explicitly. Behavior is unchanged for now. Fixes sharkdp#3752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warn when users pass the deprecated
autostyle component (--style=autoorBAT_STYLE=auto). Decoration visibility should be controlled via--decorations=auto(the default), not--style.Changes
src/style.rs—StyleComponentList::contains_auto()src/bin/bat/app.rs— emitbat_warning!whenautoappears in--styletests/integration_tests.rs— assert warning inpiped_output_with_auto_styleCHANGELOG.md— unreleased entryBehavior
No functional change yet; only a deprecation warning. Existing
piped_output_with_auto_stylebehavior is preserved.Fixes #3752
Test plan
cargo test --test integration_tests piped_output_with_auto_stylecargo clippy --all-targets --all-features -- -D warningsMade with Cursor