Fix compiler error and clarify instructions#1668
Merged
Merged
Conversation
manyinsects
approved these changes
Sep 8, 2023
Member
|
@all-contributors please add @ob for content |
Contributor
|
@shadows-withal I've put up a pull request to add @ob! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion on #1195 a commit added
.to_mut()to the lastCow::from(slice)call. However that doesn't compile (or make sense for that matter, since it returns the mutable inner type). I think from reading the comments in this commit that the comments are talking about the.to_mut()call in theabs_all()function and the commit that added the call just misinterpreted what the comments say. At any rate, this makes it compile.