go/consensus/cometbft/api: Remove message execution from context#6535
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/trivial/rename-msg-execution
branch
from
6b133a0 to
8c4c2f1
Compare
kostko
reviewed
May 23, 2026
Member
kostko
left a comment
kostko
left a comment
There was a problem hiding this comment.
I don't think I like this as the context should be more general than an individual app (roothash)?
peternose
force-pushed
the
peternose/trivial/rename-msg-execution
branch
from
8c4c2f1 to
0a904bc
Compare
kostko
approved these changes
May 26, 2026
peternose
changed the title
peternose
force-pushed
the
peternose/trivial/rename-msg-execution
branch
from
0a904bc to
ed64c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application
roothashuses a message execution context when processing and executing runtime messages. This context was introduced solely to reject runtime escrow messages when they are forbidden by consensus. Therefore, it should not be used in other applications. However, since thevaultapplication can also process and execute messages, the current naming implies that it should use the aforementioned context as well. To avoid this ambiguity, we are renaming the message execution context to roothash execution context, emphasizing that only roothash messages are executed within this context.UPDATE: Since renaming was a bad idea, this PR introduces sender of application messages and uses it to figure out the origin of the message and then decide if it comes from roothash or not.