Fix broken HTML table in report goal when using maven-site-plugin:4.0.0-M4

[nyg]

Fixes #163

First argument is for the columns text justification (null means left by default) and second argument is to draw borders but if set to true it will remove the style of the table.

https://maven.apache.org/doxia/doxia/doxia-sink-api/apidocs/org/apache/maven/doxia/sink/Sink.html#tableRows-int:A-boolean-

Let me know if you prefer constants or local variables to make this more explicit.

Before:

After:

[jcgay]

Thanks you very much for the investigation and the fix 👍

Do you think it is possible to verify the correct behavior with a test ? There is already one available for this goal but maybe we could add another one with the new maven-site-plugin ?

[github-actions]

Test Results

41 tests  +1   41 ✔️ +1   3m 50s ⏱️ + 1m 2s
14 suites ±0     0 💤 ±0 
14 files   ±0     0 ❌ ±0 

Results for commit b548159. ± Comparison against base commit 050e73e.

♻️ This comment has been updated with latest results.

[nyg]

Thanks for the feedback!

I can add a test, e.g. generate_report_with_maven_site_plugin_v4, and create a new folder next to "generate_report_for_multimodule_project" containing only a single pom.xml with the v4 of maven-site-plugin.

Would it be ok?

[nyg]

@jcgay Did you have time to look at the test I added? Thanks :)

[jcgay]

@jcgay Did you have time to look at the test I added? Thanks :)

Yes, looks good to me! I'm merging it! Thanks again 😇