Deduplicate ElectronApplication declaration in generated type sources#41199
Open
Copilot wants to merge 2 commits into
Open
Deduplicate ElectronApplication declaration in generated type sources#41199Copilot wants to merge 2 commits into
ElectronApplication declaration in generated type sources#41199Copilot wants to merge 2 commits into
Conversation
Co-authored-by: yury-s <9798949+yury-s@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicate export of ElectronApplication interface
Deduplicate Jun 8, 2026
ElectronApplication declaration in generated type sources
yury-s
approved these changes
Jun 8, 2026
dcrousso
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElectronApplicationwas being exported twice in generatedtypes.d.tsfiles becauseutils/generate_types/overrides.d.tsdefined it twice. This caused duplicated interface output in both core and client type bundles.Root cause
utils/generate_types/overrides.d.tscontained two identical blocks:type ElectronType = typeof import('electron')export interface ElectronApplication { ... }Change made
ElectronType+ElectronApplicationblock fromutils/generate_types/overrides.d.ts.Generated output impact
ElectronApplicationdefinition in:packages/playwright-core/types/types.d.tspackages/playwright-client/types/types.d.tsBefore/after (source override)