Fix tests for Java 17+#112
Merged
Merged
Conversation
Contributor
Author
|
Hello @jiaqi, Did you have some time to review my PRs? Please let me know if there's anything I can improve or change. Thanks a lot! Best, |
jiaqi
approved these changes
Mar 29, 2024
Contributor
Author
|
Hello @jiaqi, thanks for approving! Could you merge too? |
Open
Contributor
Author
|
Any news? Thanks! @jiaqi |
jiaqi
approved these changes
Apr 26, 2025
nyg
pushed a commit
to nyg/jmxsh
that referenced
this pull request
Sep 7, 2025
Bumps eclipse-temurin from 24_36-jre-alpine to 24.0.1_9-jre-alpine. --- updated-dependencies: - dependency-name: eclipse-temurin dependency-version: 24.0.1_9-jre-alpine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have not able to run mvn clean install with Java 21. The issue was due to unit tests failing. I fixed it by:
So now jmxterm can be built using Java 21, but running it still fails when listing JVM (due to other issues).
Best,
nyg