Skip to content

audit: #67 fix "Logs JSON-RPC endpoint lacks validation for filter query parameters"#588

Merged
bas-io merged 2 commits into
fix-reviewfrom
fix/limit-evm-log-topic-num
Apr 14, 2025
Merged

audit: #67 fix "Logs JSON-RPC endpoint lacks validation for filter query parameters"#588
bas-io merged 2 commits into
fix-reviewfrom
fix/limit-evm-log-topic-num

Conversation

@bas-io
Copy link
Copy Markdown
Collaborator

@bas-io bas-io commented Apr 14, 2025

No description provided.

"github.com/iotaledger/wasp/packages/vm/gas"
)

const maxLogsTopics = 4
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You recreate Go-Ethereums behavior here, right? Could you add a comment over the const to clarify this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@bas-io bas-io merged commit 2afbba7 into fix-review Apr 14, 2025
@bas-io bas-io deleted the fix/limit-evm-log-topic-num branch April 14, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants