Make ChainMgr use a bit more event-based instead of polling.#488
Merged
Conversation
Signed-off-by: Karolis Petrauskas <karolis.petrauskas@erisata.lt>
lmoe
approved these changes
Jan 27, 2025
Contributor
Author
|
@lmoe, have I broken the tests, or is it still the norm to have them fail? |
Contributor
|
Looks like other error |
Collaborator
|
Hmm. I don't remember seeing tests fail there. I'm unsure if the wrong blockindex error is intended in the tests. (As you poll to wait for a new block, or so) But it seems something is broken I havent seen before. It doesnt seem like its caused by your PR except for the message above with the different state hash that Yang Hao pointed out (which is fine, but must be adjusted with the env variable in your branch) |
Contributor
|
For now you can ignore the warning about the DB hash mismatch. It is not an error, just a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should reduce logging and also the CPU usage for re-checking the cmtlog output.