Skip to content

Make ChainMgr use a bit more event-based instead of polling.#488

Merged
kape1395 merged 2 commits into
developfrom
scriptsizefix5
Jan 29, 2025
Merged

Make ChainMgr use a bit more event-based instead of polling.#488
kape1395 merged 2 commits into
developfrom
scriptsizefix5

Conversation

@kape1395
Copy link
Copy Markdown
Contributor

Should reduce logging and also the CPU usage for re-checking the cmtlog output.

Signed-off-by: Karolis Petrauskas <karolis.petrauskas@erisata.lt>
@kape1395
Copy link
Copy Markdown
Contributor Author

@lmoe, have I broken the tests, or is it still the norm to have them fail?

@howjmay
Copy link
Copy Markdown
Contributor

howjmay commented Jan 28, 2025

Looks like other error

testdbhash.go:111: State hash for core contract "governance" has changed! This may be due to a BREAKING CHANGE; make sure that you add a migration (if necessary), and then run all tests again with: UPDATE_DBHASHES=1 (e.g. `UPDATE_DBHASHES=1 make test`). Note: you can set DB_DUMP=1 in one branch and DB_DUMP=2 on another, and then compute a diff of the generated hex dumps.

@lmoe
Copy link
Copy Markdown
Collaborator

lmoe commented Jan 28, 2025

Hmm. I don't remember seeing tests fail there. I'm unsure if the wrong blockindex error is intended in the tests. (As you poll to wait for a new block, or so)

But it seems something is broken I havent seen before. It doesnt seem like its caused by your PR except for the message above with the different state hash that Yang Hao pointed out (which is fine, but must be adjusted with the env variable in your branch)

@dessaya
Copy link
Copy Markdown
Contributor

dessaya commented Jan 28, 2025

For now you can ignore the warning about the DB hash mismatch. It is not an error, just a warning.

@kape1395 kape1395 merged commit e6b0a0e into develop Jan 29, 2025
@kape1395 kape1395 deleted the scriptsizefix5 branch January 29, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants