feat: Limit the size of AssetsBag attached in Requests#485
Merged
Conversation
howjmay
force-pushed
the
req-assetsbag-limit
branch
2 times, most recently
from
3a8e040 to
7071c3e
Compare
nnikolash
reviewed
Jan 27, 2025
| // The size of the assets bag of a request exceeds the size limit | ||
| const EAssetsBagSizeExceedLmit: u64 = 1; | ||
|
|
||
| const ReqAssetsBagSizeLimit: u32 = 25; |
Collaborator
There was a problem hiding this comment.
Isn't 25 like super low? Shouldn't it be something practically unreachable, like 100 or 500?
Collaborator
There was a problem hiding this comment.
Nah, I told him to use 25 for now. Native Coins won't be a big thing and I would be surprised if someone sends 3 at once.
I'd rather process more requests than to process a big asset bag
lmoe
approved these changes
Jan 27, 2025
| @@ -1 +1 @@ | |||
| {"modules":["oRzrCwYAAAALAQASAhIkAzaoAQTeASIFgAKnAQenA8wDCPMGYAbTBwoK3QcIDOUHjwMN9AoEAAoCCwINAhECEgIaAigBCQEpAAAMAAEBBAEAAQICDAEAAQUDBwAFBwQABgUCAAcEBwAIBgcAABkAAQAADwECAAAdAwIBAAAeBAIBAAAbBQIBDAAmBgcBAAAjCAcBAAAkCQoBDAAfBAIBAAAcBQIBDAAnBgcBAAAlCQoBDAEQBwIBAAEYFhcBAAEiHQcBAAEqHhcBAAIWDQcBAAMIGAICBwQDDBEVAgcEAxMTFAEHAyAREgIHBAQIGAICBwwEIBESAgcMBQ4LAgAFFRkaAQgFGQALAAgUAg8BAAgXDw4AEAoICgkKCgoaChQQCwoTDhIQDQoREBgKFRsOCg8KDAoWGwEHCAUBCAAAAgcIAAsCAQkAAgcIAAsBAQkAAgcIAAkAAgcIAAMBCwEBCQABBwgAAgcIAAgDAQkAAQgEAggEAwELAgEJAAEIBgEIBwIIBgsBAQkAAgcIBAkAAQkBAgYIBAkAAQEBBwkBAgcLAQEJAAsBAQkAAQMDBwgECQAJAQEGCQABCAMCCAMJAAMIBgcLAQEJAAsBAQkAAgcLAQEJAAMBBgsBAQkACUFzc2V0c0JhZwdCYWxhbmNlBENvaW4CSUQGU3RyaW5nCVR4Q29udGV4dAhUeXBlTmFtZQNVSUQDYWRkBWFzY2lpCmFzc2V0c19iYWcHYmFsYW5jZQpib3Jyb3dfbXV0BGNvaW4GZGVsZXRlDWRlc3Ryb3lfZW1wdHkMZGVzdHJveV96ZXJvDWR5bmFtaWNfZmllbGQUZHluYW1pY19vYmplY3RfZmllbGQHZXhpc3RzXwNnZXQCaWQMaW50b19iYWxhbmNlC2ludG9fc3RyaW5nBGpvaW4DbmV3Bm9iamVjdAtwbGFjZV9hc3NldBRwbGFjZV9hc3NldF9pbnRlcm5hbApwbGFjZV9jb2luEnBsYWNlX2NvaW5fYmFsYW5jZRtwbGFjZV9jb2luX2JhbGFuY2VfaW50ZXJuYWwGcmVtb3ZlBHNpemUFc3BsaXQVdGFrZV9hbGxfY29pbl9iYWxhbmNlCnRha2VfYXNzZXQTdGFrZV9hc3NldF9pbnRlcm5hbBF0YWtlX2NvaW5fYmFsYW5jZRp0YWtlX2NvaW5fYmFsYW5jZV9pbnRlcm5hbAp0eF9jb250ZXh0CXR5cGVfbmFtZQV2YWx1ZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgMIAAAAAAAAAAAAAgIVCAQhAwABAAACBQsAERkGAAAAAAAAAAASAAIBAQAADA4LABMADAIMAQsCBgAAAAAAAAAAIQQJBQsHACcLAREXAgIBAAAHBwsBOAAMAgsACwI4AQIDAQAAAgQLAAsBOAECBAEAAAIECwALATgCAgUBAAACBAsACwE4AwIGAQAADhA4BBEbDAEKABAAFAYBAAAAAAAAABcKAA8AFQsADwELATgFAgcBAAACBAsACwE4BgIIAAAADh44BBEbDAIKABABCgI4BwQQCwAPAQsCOAgLATgJAQUdCgAPAQsCCwE4CgoAEAAUBgEAAAAAAAAAFgsADwAVAgkAAAACDwoADwEOATgLCwE4DAoAEAAUBgEAAAAAAAAAFgsADwAVAgoAAAAcJDgEERsMAgoADwEKAjgIDAMKAwsBOA0MBAsDLjgOBgAAAAAAAAAAIQQgCgAPAQsCOAU4DwoAEAAUBgEAAAAAAAAAFwsADwAVBSILAAELBAILAAAAAg0KABAAFAYBAAAAAAAAABcKAA8AFQsADwELATgQAgABAAAA","oRzrCwYAAAAMAQAQAhAwA0BGBIYBCgWQAXcHhwLOAgjVBGAGtQUKCr8FMgzxBcQBDbUHAg+3BwIAHwIQAhcCHQIkAiUADgEjAAMGAAABBgAABggAAAcDAAEFBAEMAAMCBwADCgQABAQCAQgBBQkCAAYADAAHCAcAABMAAQAAFQIDAAAhBAEAAB4FAgABFRAUAQwBHA8QAQwCFhQBAQMDFAsBAAMcCgsAAyYSEwAEHhcUAQgEJBYBAQgFIgwNAAUOBA4GFQsCCgIJBQgJDg4KCgIKCAoKAwMHCAgAAQgCAggFCAkCCAIFAgcIBgsHAQgCAwoIAQMIAQEICgEDAQgBAQcICAEIBgEGCAgBBQEICQIJAAcICAELBAEJAAMLBAEICQgGCAUBBggGAQgFAQkAAQgDAgkABQIHCAYLBwEJAAlBc3NldHNCYWcNQ29pbkFsbG93YW5jZQJJRAdNZXNzYWdlCVJlY2VpdmluZwhSZWZlcmVudAdSZXF1ZXN0DFJlcXVlc3RFdmVudAZTdHJpbmcJVHhDb250ZXh0A1VJRAlhbGxvd2FuY2UGYW5jaG9yBGFyZ3MKYXNzZXRzX2JhZwdiYWxhbmNlBmJvcnJvdwljb2luX3R5cGUIY29udHJhY3QXY3JlYXRlX2FuZF9zZW5kX3JlcXVlc3QGZGVsZXRlB2Rlc3Ryb3kEZW1pdAVldmVudAhmdW5jdGlvbgpnYXNfYnVkZ2V0AmlkB21lc3NhZ2UDbmV3Bm9iamVjdAdyZWNlaXZlB3JlcXVlc3QKcmVxdWVzdF9pZARzZW5kBnNlbmRlcgZzdHJpbmcIdHJhbnNmZXIKdHhfY29udGV4dAx1aWRfdG9faW5uZXIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIDCAAAAAAAAAAAAAIDEg4YDg0KCgIBAgIRCAoPAwICBhoIBiIFDgsEAQgJGwgACwoIARkDAwICIAgFDAUAAQAABjMOBUEHDAoKCg4GQQghBAkFDQsIAQcAJ0AJAAAAAAAAAAAMCQoKBgAAAAAAAAAAJAQhDQVFBw0GRQgSAQwLDQkLC0QJCwoGAQAAAAAAAAAXDAoFDwoIEQgKCC4RDAsBCwg4AAsCCwMLBBIACwkLBxICCwARAgIBAQAAERELABMCAQEBDAEBDAIOAhEJDAMLAhEHCwMLATgBAgIAAAABCg4AEAARCQoBEgM4AgsACwE4AwIDAwAAAQQLAAsBOAQCAgAADAA=","oRzrCwYAAAAKAQAUAhQ8A1BnBLcBEAXHAagBB+8C/gII7QVgCs0GFwzkBtkBDb0ICAANAhACEgIYAhsCJwIpAA8AIQEcAAAMAAAHAAABAgAAAQkEAQwAAgMMAQABAwUCAAQEBwAEDAQABQgCAQgBBgsCAAcBDAAICggACQYHAQAAACQAAQAAFAECAAARAwQAACMFBgAAIAcIAAAoCQYAARAWFwEMARQUDwEMARoTFAEMAR4YBgEMBBMSBgAEGgoSAAcaCgIABx0RBgEACBQaGwAIHxkaAAkVDgYBAAkWDg8BAAkZDA0BABILEQsNEBALCAIHAgYCCQIDCgILDAELBAEIBQcICQEIAAEICgEHCAACCAoIAgMHCAAICggCAAIHCAALCAEICwIIAQgKAwcIAAoCCggBAQcICQELBAEIBQEGCwwBCQABAQELDAEJAAEJAAEIBQIHCAoLBAEJAAEIBwIJAAcICQELAwEJAAELAwEICgEHCwMBCQACCQAIAgMHCwMBCQAJAAgCAgcIBwsIAQgLAQgLAggGCAoCAwMBCAEGQW5jaG9yCUFzc2V0c0JhZwZCb3Jyb3cEQ29pbgJJRARJT1RBBk9wdGlvbgdSZWNlaXB0CVJlY2VpdmluZwhSZWZlcmVudAdSZXF1ZXN0CVR4Q29udGV4dANVSUQGYW5jaG9yBmFzc2V0cwphc3NldHNfYmFnBmJvcnJvdw1ib3Jyb3dfYXNzZXRzBGNvaW4GZGVsZXRlB2Rlc3Ryb3kMZGVzdHJveV9ub25lDGRlc3Ryb3lfc29tZQJpZARpb3RhB2lzX3NvbWUDbmV3Bm9iamVjdAZvcHRpb24KcGxhY2VfY29pbghwdXRfYmFjawdyZWNlaXZlD3JlY2VpdmVfcmVxdWVzdAdyZXF1ZXN0CnJlcXVlc3RfaWQZcmV0dXJuX2Fzc2V0c19mcm9tX2JvcnJvdw9zdGFydF9uZXdfY2hhaW4Lc3RhdGVfaW5kZXgOc3RhdGVfbWV0YWRhdGEIdHJhbnNmZXIKdHJhbnNpdGlvbgp0eF9jb250ZXh0AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAIEFwgHDgsDAQgKJgoCJQ4BAgEiCAYAAQAAAhYKAhEMDAMOATgABAsNAwsBOAE4AgUNCwE4AwoCEQsLAwsCOAQLAEkAAAAAEgACAQEAABUJCwATAAEBDAERCgsBOAUCAgEAAAYECwAPADgGAgMBAAAGBgsADwALAQsCOAcCBAEAAAIJCwAPAQsBEQ8RDgwCEgELAgIFAQAAHCIOAkEdDAQGAAAAAAAAAAAMAwoDCgQjBBMFCg0CRR0TAQELAwYBAAAAAAAAABYMAwUFCwJGHQAAAAAAAAAACwEKAA8CFQoAEAMUSQEAAAAWCwAPAxUCAAEAAAACAAMA"],"dependencies":["0x0000000000000000000000000000000000000000000000000000000000000002","0x0000000000000000000000000000000000000000000000000000000000000001","0x000000000000000000000000000000000000000000000000000000000000107a"],"digest":[55,84,58,237,35,146,184,189,40,212,85,132,56,143,204,16,101,14,86,27,164,119,38,26,11,49,78,35,195,88,149,235]} | |||
| {"modules":["oRzrCwYAAAALAQASAhIkAzatAQTjASIFhQKrAQewA9UDCIUHYAblBwoK7wcIDPcHmwMNkgsEAAoCCwINAhECEgIbAikBCQEqAAAMAAEBBAEAAQICDAEAAQUDBwAFBwQABgUCAAcEBwAIBgcAABoAAQAADwECAAAVAwQAAB4FAgEAAB8GAgEAABwHAgEMACcICQEAACQKCQEAACULDAEMACAGAgEAAB0HAgEMACgICQEAACYLDAEMARAJAgEAARkYBAEAASMeCQEAASsfBAEAAhcPCQEAAwgZAgIHBAMMExcCBwQDExUWAQcDIRMUAgcEBAgZAgIHDAQhExQCBwwFDg0CAAUWGhsBCAUaAA0ACBQCEQEACBgREAARDAkMCgwLDBsMFRIMDBQQExIODBISGQwWHA8MEAwNDBccAQcIBQEIAAABBggAAQMCBwgACwIBCQACBwgACwEBCQACBwgACQACBwgAAwELAQEJAAEHCAACBwgACAMBCQABCAQCCAQDAQsCAQkAAQgGAQgHAggGCwEBCQACBwgECQABCQECBggECQABAQEHCQECBwsBAQkACwEBCQADBwgECQAJAQEGCQABCAMCCAMJAAMIBgcLAQEJAAsBAQkAAgcLAQEJAAMBBgsBAQkACUFzc2V0c0JhZwdCYWxhbmNlBENvaW4CSUQGU3RyaW5nCVR4Q29udGV4dAhUeXBlTmFtZQNVSUQDYWRkBWFzY2lpCmFzc2V0c19iYWcHYmFsYW5jZQpib3Jyb3dfbXV0BGNvaW4GZGVsZXRlDWRlc3Ryb3lfZW1wdHkMZGVzdHJveV96ZXJvDWR5bmFtaWNfZmllbGQUZHluYW1pY19vYmplY3RfZmllbGQHZXhpc3RzXwNnZXQIZ2V0X3NpemUCaWQMaW50b19iYWxhbmNlC2ludG9fc3RyaW5nBGpvaW4DbmV3Bm9iamVjdAtwbGFjZV9hc3NldBRwbGFjZV9hc3NldF9pbnRlcm5hbApwbGFjZV9jb2luEnBsYWNlX2NvaW5fYmFsYW5jZRtwbGFjZV9jb2luX2JhbGFuY2VfaW50ZXJuYWwGcmVtb3ZlBHNpemUFc3BsaXQVdGFrZV9hbGxfY29pbl9iYWxhbmNlCnRha2VfYXNzZXQTdGFrZV9hc3NldF9pbnRlcm5hbBF0YWtlX2NvaW5fYmFsYW5jZRp0YWtlX2NvaW5fYmFsYW5jZV9pbnRlcm5hbAp0eF9jb250ZXh0CXR5cGVfbmFtZQV2YWx1ZQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgMIAAAAAAAAAAAAAgIWCAQiAwABAAACBQsAERoGAAAAAAAAAAASAAIBAQAADg4LABMADAIMAQsCBgAAAAAAAAAAIQQJBQsHACcLAREYAgIBAAACBAsAEAAUAgMBAAAJBwsBOAAMAgsACwI4AQIEAQAAAgQLAAsBOAECBQEAAAIECwALATgCAgYBAAACBAsACwE4AwIHAQAAEBA4BBEcDAEKABAAFAYBAAAAAAAAABcKAA8AFQsADwELATgFAggBAAACBAsACwE4BgIJAAAAEB44BBEcDAIKABABCgI4BwQQCwAPAQsCOAgLATgJAQUdCgAPAQsCCwE4CgoAEAAUBgEAAAAAAAAAFgsADwAVAgoAAAACDwoADwEOATgLCwE4DAoAEAAUBgEAAAAAAAAAFgsADwAVAgsAAAAdJDgEERwMAgoADwEKAjgIDAMKAwsBOA0MBAsDLjgOBgAAAAAAAAAAIQQgCgAPAQsCOAU4DwoAEAAUBgEAAAAAAAAAFwsADwAVBSILAAELBAIMAAAAAg0KABAAFAYBAAAAAAAAABcKAA8AFQsADwELATgQAgABAAAA","oRzrCwYAAAAMAQAQAhAwA0BLBIsBCgWVAXsHkALXAgjnBGAGxwUaCuEFMgyTBtYBDekHAg/rBwIAIAIQAhcCHgIlAiYADgEkAAMGAAABBgAABggAAAcDAAEFBAEMAAMCBwADCgQABAQCAQgBBQkCAAYADAAHCAcAABMAAQAAFQIDAAAiBAEAAB8FAgABFREVAQwBHRARAQwCFhUBAQMDFAwBAAMdCwwAAycTFAAEHxgVAQgEJRcBAQgFIw0OAAYaBwgABQ8EDwYWCwIKAgkFCAkODgoKAgoICgoDAwcICAABCAICCAUICQIIAgUCBwgGCwcBCAIDCggBAwgBAQYICQEDAQgKAQgBAQcICAEIBgEGCAgBBQEICQIJAAcICAELBAEJAAMLBAEICQgGCAUBBggGAQgFAQkAAQgDAgkABQIHCAYLBwEJAAlBc3NldHNCYWcNQ29pbkFsbG93YW5jZQJJRAdNZXNzYWdlCVJlY2VpdmluZwhSZWZlcmVudAdSZXF1ZXN0DFJlcXVlc3RFdmVudAZTdHJpbmcJVHhDb250ZXh0A1VJRAlhbGxvd2FuY2UGYW5jaG9yBGFyZ3MKYXNzZXRzX2JhZwdiYWxhbmNlBmJvcnJvdwljb2luX3R5cGUIY29udHJhY3QXY3JlYXRlX2FuZF9zZW5kX3JlcXVlc3QGZGVsZXRlB2Rlc3Ryb3kEZW1pdAVldmVudAhmdW5jdGlvbgpnYXNfYnVkZ2V0CGdldF9zaXplAmlkB21lc3NhZ2UDbmV3Bm9iamVjdAdyZWNlaXZlB3JlcXVlc3QKcmVxdWVzdF9pZARzZW5kBnNlbmRlcgZzdHJpbmcIdHJhbnNmZXIKdHhfY29udGV4dAx1aWRfdG9faW5uZXIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAIDCAAAAAAAAAAAAwgBAAAAAAAAAA4EGQAAAAACAxIOGA4NCgoCAQICEQgKDwMCAgYbCAYjBQ4LBAEICRwIAAsKCAEZAwMCAiEIBQwFAAEAAAY+DgERDQcCNCUEBwULCwgBBwEnDgVBCQwKCgoOBkEIIQQUBRgLCAEHACdACgAAAAAAAAAADAkKCgYAAAAAAAAAACQELA0FRQkNBkUIEgEMCw0JCwtECgsKBgEAAAAAAAAAFwwKBRoKCBEICgguEQwLAQsIOAALAgsDCwQSAAsJCwcSAgsAEQICAQEAABIRCwATAgEBAQwBAQwCDgIRCQwDCwIRBwsDCwE4AQICAAAAAQoOABAAEQkKARIDOAILAAsBOAMCAwMAAAEECwALATgEAgIAAAwA","oRzrCwYAAAAKAQAUAhQ8A1BnBLcBEAXHAagBB+8C/gII7QVgCs0GFwzkBtkBDb0ICAANAhACEgIYAhsCJwIpAA8AIQEcAAAMAAAHAAABAgAAAQkEAQwAAgMMAQABAwUCAAQEBwAEDAQABQgCAQgBBgsCAAcBDAAICggACQYHAQAAACQAAQAAFAECAAARAwQAACMFBgAAIAcIAAAoCQYAARAWFwEMARQUDwEMARoTFAEMAR4YBgEMBBMSBgAEGgoSAAcaCgIABx0RBgEACBQaGwAIHxkaAAkVDgYBAAkWDg8BAAkZDA0BABILEQsNEBALCAIHAgYCCQIDCgILDAELBAEIBQcICQEIAAEICgEHCAACCAoIAgMHCAAICggCAAIHCAALCAEICwIIAQgKAwcIAAoCCggBAQcICQELBAEIBQEGCwwBCQABAQELDAEJAAEJAAEIBQIHCAoLBAEJAAEIBwIJAAcICQELAwEJAAELAwEICgEHCwMBCQACCQAIAgMHCwMBCQAJAAgCAgcIBwsIAQgLAQgLAggGCAoCAwMBCAEGQW5jaG9yCUFzc2V0c0JhZwZCb3Jyb3cEQ29pbgJJRARJT1RBBk9wdGlvbgdSZWNlaXB0CVJlY2VpdmluZwhSZWZlcmVudAdSZXF1ZXN0CVR4Q29udGV4dANVSUQGYW5jaG9yBmFzc2V0cwphc3NldHNfYmFnBmJvcnJvdw1ib3Jyb3dfYXNzZXRzBGNvaW4GZGVsZXRlB2Rlc3Ryb3kMZGVzdHJveV9ub25lDGRlc3Ryb3lfc29tZQJpZARpb3RhB2lzX3NvbWUDbmV3Bm9iamVjdAZvcHRpb24KcGxhY2VfY29pbghwdXRfYmFjawdyZWNlaXZlD3JlY2VpdmVfcmVxdWVzdAdyZXF1ZXN0CnJlcXVlc3RfaWQZcmV0dXJuX2Fzc2V0c19mcm9tX2JvcnJvdw9zdGFydF9uZXdfY2hhaW4Lc3RhdGVfaW5kZXgOc3RhdGVfbWV0YWRhdGEIdHJhbnNmZXIKdHJhbnNpdGlvbgp0eF9jb250ZXh0AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAIEFwgHDgsDAQgKJgoCJQ4BAgEiCAYAAQAAAhYKAhEMDAMOATgABAsNAwsBOAE4AgUNCwE4AwoCEQsLAwsCOAQLAEkAAAAAEgACAQEAABUJCwATAAEBDAERCgsBOAUCAgEAAAYECwAPADgGAgMBAAAGBgsADwALAQsCOAcCBAEAAAIJCwAPAQsBEQ8RDgwCEgELAgIFAQAAHCIOAkEdDAQGAAAAAAAAAAAMAwoDCgQjBBMFCg0CRR0TAQELAwYBAAAAAAAAABYMAwUFCwJGHQAAAAAAAAAACwEKAA8CFQoAEAMUSQEAAAAWCwAPAxUCAAEAAAACAAMA"],"dependencies":["0x0000000000000000000000000000000000000000000000000000000000000002","0x0000000000000000000000000000000000000000000000000000000000000001","0x000000000000000000000000000000000000000000000000000000000000107a"],"digest":[5,160,180,193,18,150,145,64,222,155,114,22,125,75,0,39,78,51,46,130,97,148,19,140,175,24,77,175,62,25,232,86]} | |||
Collaborator
There was a problem hiding this comment.
Is the bytecode compiled with the newest iota cli?
If not please do so.
Contributor
Author
There was a problem hiding this comment.
rebuilt with v0.8.1. Nothing changed
Client/Server api version mismatch, client api version: 0.8.1-rc, server api version: 0.9.0-alpha
| // The size of the assets bag of a request exceeds the size limit | ||
| const EAssetsBagSizeExceedLmit: u64 = 1; | ||
|
|
||
| const ReqAssetsBagSizeLimit: u32 = 25; |
Collaborator
There was a problem hiding this comment.
Nah, I told him to use 25 for now. Native Coins won't be a big thing and I would be surprised if someone sends 3 at once.
I'd rather process more requests than to process a big asset bag
howjmay
force-pushed
the
req-assetsbag-limit
branch
from
7071c3e to
cab3e03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.