Simplify nREPL startup and correct incidental-complexity A2 gate#158
Merged
Conversation
1a8dd02 to
edfe077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the completed
run-simplificationwork for Munera tasks 214 and 215.214 — simplify
start-nrepl!psi.app-runtime.nrepl-runtime/start-nrepl!behaviour:.nrepl-portis written/deleted with the expected ownership rules,start-nrepl!by extracting cohesive helper seams for the nREPL start mechanics and endpoint publication, preserving behaviour while reducing the target's local comprehension burden.215 — correct the
reduce-incidental-complexityA2 gate.psi/workflows/reduce-incidental-complexity.ednso future generated tasks no longer emit the broken net-sum A2 gate.B := before(target)from committedbefore-local.json,after(u) < B,after(u) < B,θ/ε, no net sum.before-local.json+ recomputedbb gordian local --json:(ns, var, arity)grouping,before-max(k)for non-unique keys,after(u)checks,T,gordian-net-sum-burden-gate-sub-additivity.mdrecords the fix landed and supersedes the earlierafter(target)residual-anchor sketch with the committed-baselineafter(u) < Bform.editing-workflow-emitter-prompts.mdcaptures workflow-emitter editing/test lessons from this work.Verification
bb clojure:test:scry --namespace psi.app-runtime-nrepl-test→ 7 tests / 30 assertions GREEN.bb lint/ targeted clj-kondo checks clean for touched code paths (one pre-existing informational warning noted in task artifacts where applicable).start-nrepl!lcc-total reduced from6.015383232244966to5.549920815558428,gordian gate --baseline ... --fail-on new-cycles,new-high-findings --max-new-medium-findings 0passes.clj-kondoover the touched workflow-definition test file reports 0 errors / 0 warnings.Known pre-existing caveat recorded in the task artifacts: a full kaocha
--focusinvocation can fail while loading an unrelated namespace (psi.agent_session.tool_execution_test→ missingpsi/metrics/extensionon the classpath). The affected workflow-loader suite was isolated and run directly from repo root because those tests read.psi/workflows/cwd-relative.Notes
munera/closed/214-simplify-start-nreplmunera/closed/215-correct-incidental-complexity-a2-gate