Skip to content

robustness: fix mixed-version robustness test failing#21923

Open
henrybear327 wants to merge 1 commit into
etcd-io:mainfrom
henrybear327:robustness/fix_mismatch_entry
Open

robustness: fix mixed-version robustness test failing#21923
henrybear327 wants to merge 1 commit into
etcd-io:mainfrom
henrybear327:robustness/fix_mismatch_entry

Conversation

@henrybear327
Copy link
Copy Markdown
Contributor

In areEntriesEqual, the data is compared strictly. But due to the protobuf library update, v3.6 write the default value to the data, but v3.7 doesn't, causing the comparison to fail.

Ref: #21908

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrybear327 henrybear327 force-pushed the robustness/fix_mismatch_entry branch from 1bf0da8 to 9e8ab5f Compare June 6, 2026 17:29
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.79%. Comparing base (eb8b216) to head (7e58172).

Additional details and impacted files

see 32 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21923      +/-   ##
==========================================
+ Coverage   69.64%   69.79%   +0.15%     
==========================================
  Files         449      449              
  Lines       38208    38208              
==========================================
+ Hits        26610    26669      +59     
+ Misses      10172    10117      -55     
+ Partials     1426     1422       -4     

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8b216...7e58172. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrybear327
Copy link
Copy Markdown
Contributor Author

/retest

Ref: etcd-io#21908 (comment)

Signed-off-by: Chun-Hung Tseng <henrytseng@google.com>
@henrybear327 henrybear327 force-pushed the robustness/fix_mismatch_entry branch from 9e8ab5f to 7e58172 Compare June 6, 2026 21:57
@k8s-ci-robot
Copy link
Copy Markdown

@henrybear327: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 7e58172 link true /test pull-etcd-robustness-amd64
pull-etcd-e2e-amd64 7e58172 link true /test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants