Fix calling without argument warnings#31
Merged
Conversation
Remove public since it does not generate "private attribute?" warnings and for following warning warning: calling public without arguments inside a method may not have the intended effect Check if names are not empty to fix following warning: warning: calling private without arguments inside a method may not have the intended effect This warning was introduced by ruby/ruby@2993b24 from issue: https://bugs.ruby-lang.org/issues/13249
Member
|
Thank you! We were about to look into this but this saves us the trouble :) I tried running the tests with this change on Ruby 2.5.1 and 2.6.5, and it didn't show a "private attribute?" warning (even with |
Member
|
We changed it to a guard :) 1305e6c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this Pull Request has 2 changes:
Remove public since it does not generate "private attribute?" warnings and this also fixes for following warning
Check if names are not empty to fix following warning:
These calling without arguments warnings introduced by ruby/ruby@2993b24 from ruby bug tracker #13249.
I‘m not a fan of adding this
if, but \_(ツ)_/.Open to better suggestion, thanks!