fix(rtmp): prevent index out of range panic in encodeFLV#2241
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
The bounds check hint asserted b[15] exists, but the buffer only needs to hold 15 bytes (4 prev-tag-size + 11 header) when the payload is empty. Lower the assertion to b[14] so an empty payload no longer panics. Closes AlexxIT#2061. Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2061.
The compiler bounds-check hint at
pkg/rtmp/flv.go:58assertedb[15]exists, but the buffer only needs to hold 15 bytes (4 prev-tag-size + 11 header) when the payload is empty, panicking withindex out of range [15] with length 15. Lower the assertion to the last actually-written single byte (b[14]); the subsequentcopy(b[4+11:], payload)is a no-op for empty payloads.