Remove myself as reviewer from pull requests

[loic-sharma]

Hello! 👋

Problem

I would like to use the "Review Requests" page to track what needs my attention: https://github.com/pulls/review-requested

I've changed companies and lost permissions to repositories that are owned by my previous employer. However, I'm still listed as a reviewer on several stale pull requests. I do not have permissions to close these stale pull requests, or, to remove myself as a reviewer. As a result, the "Review Requests" page is polluted with items I cannot remove myself.

Suggestion

Allow users to remove themselves as a requested reviewer from a pull request even if they do not have permissions for that repository.

See this discussion: https://gh.1s.fanmunity/t/how-to-remove-a-reviewer-from-a-pull-request/1415

[ghost]

Hey! I found a following way:

• open a PR
• locate the list of PR reviewers
• on top of the list there's "Reviewers" button with a "gear" icon. Click on it
• in the drop-down list of the reviewers locate yourself
• uncheck yourself from the list, this should remove you from the list
• repeat for the other PRs

[jsoref]

I was replying to @joshterrill.

Offhand, it looks like you could technically "request changes" or "approve". Obviously neither of these are great, but, a change of "please get me out of here, I'm trapped" is a kinda valid response.

Fwiw, I gave up and filed a ticket based on this issue. I agree that one should be able to quietly leave the request list w/o having Triage or better permissions.

[joshterrill]

@jsoref that's correct, the whole process is weird. I've actually taken a video recording showing what I mean. Here is me, being an admin of an organization, and an admin of a repo, starting to create a PR, adding someone, then I can't remove them, I can only add another person. Then I create the PR, and I still can't remove them, I can only change who it is assigned to. When all I want to do is just remove the reviewer all together. See attached video.

Untitled_.Aug.5.2022.11_45.AM.mp4

[jsoref]

So. I suspect that it you pushed an extra commit to the branch, you'd be able to use the dismiss stale requests bit.

I should have taken a video of mine. I'll have to get permission from someone.

At the end, after you've created the PR, can you still not remove the current requestee from the right sidebar?

Also, is it relevant that your PR has a merge conflict?

(I used a brand new repository with only two commits for testing.)

[joshterrill]

@jsoref

1. I just created a test commit in a branch to test this, so the commit was made just before the PR
2. Yes, after I create the PR, I still cannot remove the requestee from the sidebar, this is shown in my video at ~0:49
3. In my video, it had a conflict, when I discovered this and what led me to comment, there was no conflict. If you want me to reproduce this and show you without a conflict, I can, but I get the same results.

[jsoref]

Hmm, this is fun. -- If a reviewer no longer has read permission, the 🔄 widget doesn't do anything useful and doesn't explain that it doesn't work.

Here's me trying to show that it's possible occasionally to do things:
https://user-images.github.com/2119212/183197671-437f39d3-5f63-44f6-b942-51fdb2051cb2.mov

I think I'd need to reduce my screen res (this was actually a tiny window when I recorded it, but...).

Note that in my case the reviewer in question actually had created a review -- we played w/ it where they hadn't as well. The UI is clearly quite rough and hasn't had enough complaints to force it into a particularly smooth state.

[parberge]

https://github.com/orgs/community/discussions/23054 also speaks about the problem that a user show up as a reviewer when you write a comment, and that user can't be removed from the list even if it's not a required reviewer.

Will this feature request cover that use case also?

[holmbergjonas]

Yes, it will also be added to things never to do or speak of 👍

[nusrantham]

remove Cloning a repository